Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conversation): maintain 1:1 mapping of message to item #2910

Closed
wants to merge 25 commits into from
Closed

fix(conversation): maintain 1:1 mapping of message to item #2910

wants to merge 25 commits into from

Conversation

atierian
Copy link
Member

Note

This PR includes changes from #2897, #2898, and #2909.
Keeping it in draft until those are merged.

Description of changes

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian
Copy link
Member Author

Adding comment from previous PR as a reminder to include this change here.
#2897 (comment)

@atierian atierian mentioned this pull request Sep 26, 2024
Merged
7 tasks
@atierian
use .template.js for that sweet sweet syntax highlighting in gh
e49417d
@atierian
update prettierignore
4bf5ce5
@atierian
refactor(generation): use file templates for JS resolvers
0848609
@atierian
use [[KEY]] marker for substitution
fda30fb
@atierian
add test case with valid inference configuration
eab9624
@atierian
lint
504d430
@atierian
update snapshots post lint
86440f1
@atierian
use .js.template for resolver function templates
9129e5c
@atierian
use .template.js for that sweet sweet syntax highlighting in gh
e047843
@atierian
fix(conversation): missing aiContext in message payload
70ce4fd
@atierian
fix(conversation): split messages by role and use existing GSI for cr…
f0e578d 
…eatedAt DESC order in list queries
@atierian
fix IndexName -> index in otherwise unused query list resolver
45d1538
@atierian
use messageHistoryQuery, remove messages from lambda payload
af6ffc1
@atierian
update conversation snapshots for listqueryname typo
0269fa0
@atierian
use messageHistoryQuery, remove messages from lambda payload
bef11d4
@atierian
remove assistantContent, add associatedUserMessageId for item level m…
82fd92c 
…essages
@atierian
update assistant response resolver pipeline to reflect 1:1 message:it…
59b91b0 
…em mapping
@atierian
update snapshots
ef639c7
@atierian
Copy link
Member Author

atierian commented Oct 4, 2024

Closed in favor of #2914

@atierian atierian closed this Oct 4, 2024
@atierian atierian deleted the ai.conversation-message-shape branch November 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atierian